Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: Simplify call log code

Browse Source
This commit is contained in:
Suraj Shetty 2022-05-08 16:05:04 +05:30
parent 53e4fee4db
commit e0bc437ddb
1 changed files with 21 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
erpnext/telephony/doctype/call_log/call_log.py
View File

@ -24,12 +24,10 @@ class CallLog(Document):
lead_number = self.get("from") if self.is_incoming_call() else self.get("to")
lead_number = strip_number(lead_number)
contact = get_contact_with_phone_number(strip_number(lead_number))
if contact:
if contact := get_contact_with_phone_number(strip_number(lead_number)):
self.add_link(link_type="Contact", link_name=contact)
lead = get_lead_with_phone_number(lead_number)
if lead:
if lead := get_lead_with_phone_number(lead_number):
self.add_link(link_type="Lead", link_name=lead)
# Add Employee Name
@ -70,7 +68,9 @@ class CallLog(Document):
self.append("links", {"link_doctype": link_type, "link_name": link_name})
def trigger_call_popup(self):
if self.is_incoming_call():
if not self.is_incoming_call():
return
scheduled_employees = get_scheduled_employees_for_popup(self.medium)
employees = get_employees_with_number(self.to)
employee_emails = [employee.get("user_id") for employee in employees]
@ -155,7 +155,7 @@ def link_existing_conversations(doc, state):
END
)=0
""",
dict(phone_number="%{}".format(number), docname=doc.name, doctype=doc.doctype),
dict(phone_number=f"%{number}", docname=doc.name, doctype=doc.doctype),
)
for log in logs:
@ -175,7 +175,7 @@ def get_linked_call_logs(doctype, docname):
filters={"parenttype": "Call Log", "link_doctype": doctype, "link_name": docname},
)
logs = set([log.parent for log in logs])
logs = {log.parent for log in logs}
logs = frappe.get_all("Call Log", fields=["*"], filters={"name": ["in", logs]})