Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

perf: Stock Entry (Material Transfer)

Browse Source
This commit is contained in:
s-aga-r 2023-03-05 21:57:02 +05:30
parent ac87fca0d7
commit de18f98c5c
1 changed files with 42 additions and 21 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

51
erpnext/manufacturing/doctype/job_card/job_card.py
View File

@ -561,8 +561,35 @@ class JobCard(Document):
) )
def set_transferred_qty_in_job_card_item(self, ste_doc): def set_transferred_qty_in_job_card_item(self, ste_doc):
def _get_job_card_items_transferred_qty(ste_doc):
from frappe.query_builder.functions import Sum from frappe.query_builder.functions import Sum
job_card_items_transferred_qty = {}
job_card_items = [
x.get("job_card_item") for x in ste_doc.get("items") if x.get("job_card_item")
]
if job_card_items:
se = frappe.qb.DocType("Stock Entry")
sed = frappe.qb.DocType("Stock Entry Detail")
query = (
frappe.qb.from_(sed)
.join(se)
.on(sed.parent == se.name)
.select(sed.job_card_item, Sum(sed.qty))
.where(
(sed.job_card_item.isin(job_card_items))
& (se.docstatus == 1)
& (se.purpose == "Material Transfer for Manufacture")
)
.groupby(sed.job_card_item)
)
job_card_items_transferred_qty = frappe._dict(query.run(as_list=True))
return job_card_items_transferred_qty
def _validate_over_transfer(row, transferred_qty): def _validate_over_transfer(row, transferred_qty):
"Block over transfer of items if not allowed in settings." "Block over transfer of items if not allowed in settings."
required_qty = frappe.db.get_value("Job Card Item", row.job_card_item, "required_qty") required_qty = frappe.db.get_value("Job Card Item", row.job_card_item, "required_qty")
@ -578,29 +605,23 @@ class JobCard(Document):
exc=JobCardOverTransferError, exc=JobCardOverTransferError,
) )
job_card_items_transferred_qty = _get_job_card_items_transferred_qty(ste_doc)
if job_card_items_transferred_qty:
allow_excess = frappe.db.get_single_value("Manufacturing Settings", "job_card_excess_transfer")
for row in ste_doc.items: for row in ste_doc.items:
if not row.job_card_item: if not row.job_card_item:
continue continue
sed = frappe.qb.DocType("Stock Entry Detail") transferred_qty = flt(job_card_items_transferred_qty.get(row.job_card_item))
se = frappe.qb.DocType("Stock Entry")
transferred_qty = (
frappe.qb.from_(sed)
.join(se)
.on(sed.parent == se.name)
.select(Sum(sed.qty))
.where(
(sed.job_card_item == row.job_card_item)
& (se.docstatus == 1)
& (se.purpose == "Material Transfer for Manufacture")
)
).run()[0][0]
allow_excess = frappe.db.get_single_value("Manufacturing Settings", "job_card_excess_transfer")
if not allow_excess: if not allow_excess:
_validate_over_transfer(row, transferred_qty) _validate_over_transfer(row, transferred_qty)
frappe.db.set_value("Job Card Item", row.job_card_item, "transferred_qty", flt(transferred_qty)) frappe.db.set_value(
"Job Card Item", row.job_card_item, "transferred_qty", flt(transferred_qty)
)
def set_transferred_qty(self, update_status=False): def set_transferred_qty(self, update_status=False):
"Set total FG Qty in Job Card for which RM was transferred." "Set total FG Qty in Job Card for which RM was transferred."