Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Enqueued item variants updation if there are more than 30 variants

Browse Source
This commit is contained in:
Nabin Hait 2019-02-12 18:30:00 +05:30
parent 1a7e438fb2
commit db527bfb24
1 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

25
erpnext/stock/doctype/item/item.py
View File

@ -700,15 +700,14 @@ class Item(WebsiteGenerator):
frappe.db.get_single_value('Item Variant Settings', 'do_not_update_variants'): frappe.db.get_single_value('Item Variant Settings', 'do_not_update_variants'):
return return
if self.has_variants: if self.has_variants:
updated = []
variants = frappe.db.get_all("Item", fields=["item_code"], filters={"variant_of": self.name}) variants = frappe.db.get_all("Item", fields=["item_code"], filters={"variant_of": self.name})
for d in variants: if variants:
variant = frappe.get_doc("Item", d) if len(variants) <= 30:
copy_attributes_to_variant(self, variant) update_variants(variants, self, publish_progress=False)
variant.save() frappe.msgprint(_("Item Variants updated"))
updated.append(d.item_code) else:
if updated: frappe.enqueue("erpnext.stock.doctype.item.item.update_variants",
frappe.msgprint(_("Item Variants {0} updated").format(", ".join(updated))) variants=variants, template=self, now=frappe.flags.in_test, timeout=600)
def validate_has_variants(self): def validate_has_variants(self):
if not self.has_variants and frappe.db.get_value("Item", self.name, "has_variants"): if not self.has_variants and frappe.db.get_value("Item", self.name, "has_variants"):
@ -997,3 +996,13 @@ def get_item_attribute(parent, attribute_value=''):
return frappe.get_all("Item Attribute Value", fields = ["attribute_value"], return frappe.get_all("Item Attribute Value", fields = ["attribute_value"],
filters = {'parent': parent, 'attribute_value': ("like", "%%%s%%" % attribute_value)}) filters = {'parent': parent, 'attribute_value': ("like", "%%%s%%" % attribute_value)})
def update_variants(variants, template, publish_progress=True):
count=0
for d in variants:
variant = frappe.get_doc("Item", d)
copy_attributes_to_variant(template, variant)
variant.save()
count+=1
if publish_progress:
frappe.publish_progress(count*100/len(variants), title = _("Updating Variants..."))