fix(hr): update leave application status on cancel (#19883)

2019-12-23 18:41:17 +05:30 · 2019-12-23 18:41:17 +05:30 · da5d5c4941
commit da5d5c4941
parent d8c10bcedb
1 changed files with 3 additions and 1 deletions
--- a/erpnext/hr/doctype/leave_application/leave_application.py
+++ b/erpnext/hr/doctype/leave_application/leave_application.py
@ -54,9 +54,11 @@ class LeaveApplication(Document):
 		self.create_leave_ledger_entry()
 		self.reload()

+	def before_cancel(self):
+		self.status = "Cancelled"
+
 	def on_cancel(self):
 		self.create_leave_ledger_entry(submit=False)
-		self.status = "Cancelled"
 		# notify leave applier about cancellation
 		self.notify_employee()
 		self.cancel_attendance()