Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

chore: Linting Issues

Browse Source
This commit is contained in:
Deepesh Garg 2022-07-11 21:50:01 +05:30
parent 13b7ed1e2c
commit d933ff5cf6
2 changed files with 7 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/loan_management/doctype/loan_balance_adjustment/loan_balance_adjustment.py
View File

@ -42,9 +42,10 @@ class LoanBalanceAdjustment(AccountsController):
self.cost_center = erpnext.get_default_cost_center(self.company) self.cost_center = erpnext.get_default_cost_center(self.company)
def set_status_and_amounts(self, cancel=0): def set_status_and_amounts(self, cancel=0):
loan_details = frappe.get_all( loan_details = frappe.db.get_value(
"Loan", "Loan",
fields=[ self.loan,
[
"loan_amount", "loan_amount",
"credit_adjustment_amount", "credit_adjustment_amount",
"debit_adjustment_amount", "debit_adjustment_amount",
@ -55,8 +56,8 @@ class LoanBalanceAdjustment(AccountsController):
"is_term_loan", "is_term_loan",
"is_secured_loan", "is_secured_loan",
], ],
filters={"name": self.loan}, as_dict=1,
)[0] )
if cancel: if cancel:
adjustment_amount = self.get_values_on_cancel(loan_details) adjustment_amount = self.get_values_on_cancel(loan_details)

11
erpnext/loan_management/doctype/loan_refund/loan_refund.py
View File

@ -3,11 +3,11 @@
import frappe import frappe
from frappe import _ from frappe import _
from erpnext.controllers.accounts_controller import AccountsController from frappe.utils import getdate
from frappe.utils import cint, getdate
import erpnext import erpnext
from erpnext.accounts.general_ledger import make_gl_entries from erpnext.accounts.general_ledger import make_gl_entries
from erpnext.controllers.accounts_controller import AccountsController
from erpnext.loan_management.doctype.loan_repayment.loan_repayment import ( from erpnext.loan_management.doctype.loan_repayment.loan_repayment import (
get_pending_principal_amount, get_pending_principal_amount,
) )
@ -27,13 +27,6 @@ class LoanRefund(AccountsController):
self.cost_center = erpnext.get_default_cost_center(self.company) self.cost_center = erpnext.get_default_cost_center(self.company)
def validate_refund_amount(self): def validate_refund_amount(self):
precision = cint(frappe.db.get_default("currency_precision")) or 2
total_payment, principal_paid, interest_payable, written_off_amount = frappe.get_value(
"Loan",
self.loan,
["total_payment", "total_principal_paid", "total_interest_payable", "written_off_amount"],
)
loan = frappe.get_doc("Loan", self.loan) loan = frappe.get_doc("Loan", self.loan)
pending_amount = get_pending_principal_amount(loan) pending_amount = get_pending_principal_amount(loan)
if pending_amount >= 0: if pending_amount >= 0: