Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ux): apply proper filtering in stock reports (#27411)

Browse Source 
* fix(ux): apply proper filtering in stock reports

Stock Balance: apply company filter to warehouse field
Stock Ageing: apply company filter to warehouse field

* fix: unnecessary parens

Co-authored-by: Alan <2.alan.tom@gmail.com>
This commit is contained in:
Ankush Menat 2021-09-12 16:38:18 +05:30 committed by GitHub
parent 6ef879fca2
commit d743c41b54
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 17 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/stock/report/stock_ageing/stock_ageing.js
View File

@ -22,7 +22,15 @@ frappe.query_reports["Stock Ageing"] = {
"fieldname":"warehouse", "fieldname":"warehouse",
"label": __("Warehouse"), "label": __("Warehouse"),
"fieldtype": "Link", "fieldtype": "Link",
"options": "Warehouse" "options": "Warehouse",
get_query: () => {
const company = frappe.query_report.get_filter_value("company");
return {
filters: {
...company && {company},
}
};
}
}, },
{ {
"fieldname":"item_code", "fieldname":"item_code",

9
erpnext/stock/report/stock_balance/stock_balance.js
View File

@ -53,13 +53,14 @@ frappe.query_reports["Stock Balance"] = {
"width": "80", "width": "80",
"options": "Warehouse", "options": "Warehouse",
get_query: () => { get_query: () => {
var warehouse_type = frappe.query_report.get_filter_value('warehouse_type'); let warehouse_type = frappe.query_report.get_filter_value("warehouse_type");
if(warehouse_type){ let company = frappe.query_report.get_filter_value("company");
return { return {
filters: { filters: {
'warehouse_type': warehouse_type ...warehouse_type && {warehouse_type},
...company && {company}
} }
};
} }
} }
}, },