Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Employee Benefit Application - validate max benefit for employee

Browse Source
This commit is contained in:
Jamsheer 2018-05-15 13:01:49 +05:30
parent 2d6901d5dc
commit d66fb842c1
2 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.js
View File

@ -20,7 +20,7 @@ frappe.ui.form.on('Employee Benefit Application', {
callback: function (data) { callback: function (data) {
if(!data.exc){ if(!data.exc){
if(data.message){ if(data.message){
frm.set_value("max_benefits", data.message) frm.set_value("max_benefits", data.message);
} }
} }
} }

12
erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py
View File

@ -9,6 +9,10 @@ from frappe.utils import nowdate
from frappe.model.document import Document from frappe.model.document import Document
class EmployeeBenefitApplication(Document): class EmployeeBenefitApplication(Document):
def validate(self):
if self.max_benefits <= 0:
frappe.throw(_("Employee {0} has no maximum benefit amount").format(self.employee))
def before_submit(self): def before_submit(self):
self.validate_duplicate_on_payroll_period() self.validate_duplicate_on_payroll_period()
self.validate_max_benefit_for_component() self.validate_max_benefit_for_component()
@ -42,7 +46,13 @@ class EmployeeBenefitApplication(Document):
def get_max_benefits(self): def get_max_benefits(self):
sal_struct = get_assigned_salary_sturecture(self.employee, self.date) sal_struct = get_assigned_salary_sturecture(self.employee, self.date)
if sal_struct: if sal_struct:
return frappe.db.get_value("Salary Structure", sal_struct[0][0], "max_benefits") max_benefits = frappe.db.get_value("Salary Structure", sal_struct[0][0], "max_benefits")
if max_benefits > 0:
return max_benefits
else:
frappe.throw(_("Employee {0} has no max benefits in salary structure {1}").format(self.employee, sal_struct[0][0]))
else:
frappe.throw(_("Employee {0} has no salary structure assigned").format(self.employee))
@frappe.whitelist() @frappe.whitelist()