From d5cb4c10a16f4339c8fbd7ba36296210a4ae96aa Mon Sep 17 00:00:00 2001 From: Nabin Hait Date: Wed, 23 May 2018 18:35:59 +0530 Subject: [PATCH] Set parent department if missing and not root itself --- erpnext/hr/doctype/department/department.py | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/erpnext/hr/doctype/department/department.py b/erpnext/hr/doctype/department/department.py index 15e30af4f8..99a9b8518c 100644 --- a/erpnext/hr/doctype/department/department.py +++ b/erpnext/hr/doctype/department/department.py @@ -3,6 +3,7 @@ from __future__ import unicode_literals import frappe +from frappe import _ from frappe.utils.nestedset import NestedSet from erpnext.utilities.transaction_base import delete_events from frappe.model.document import Document @@ -11,15 +12,16 @@ class Department(NestedSet): nsm_parent_field = 'parent_department' def autoname(self): - if not self.department_name=="All Departments": + if not self.department_name==_("All Departments"): abbr = frappe.db.get_value('Company', self.company, 'abbr') self.name = '{0} - {1}'.format(self.department_name, abbr) else: self.name = self.department_name def validate(self): - if not self.parent_department: - self.parent_department = "All Departments" + if not self.parent_department and self.department_name != _("All Departments") \ + and frappe.db.exists("Department", _("All Departments")): + self.parent_department = _("All Departments") def update_nsm_model(self): frappe.utils.nestedset.update_nsm(self)