From d5b2e39f4538e2728f60b13ee3cfe89061b83b21 Mon Sep 17 00:00:00 2001 From: Shreya Shah Date: Fri, 23 Feb 2018 16:23:57 +0530 Subject: [PATCH] improve validation (#13058) --- erpnext/selling/doctype/sales_order/sales_order.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/erpnext/selling/doctype/sales_order/sales_order.py b/erpnext/selling/doctype/sales_order/sales_order.py index 084a218005..f1b56d9bd8 100644 --- a/erpnext/selling/doctype/sales_order/sales_order.py +++ b/erpnext/selling/doctype/sales_order/sales_order.py @@ -104,8 +104,8 @@ class SalesOrder(SellingController): def validate_delivery_date(self): if self.order_type == 'Sales': if not self.delivery_date: - self.delivery_date = max([d.delivery_date for d in self.get("items") if d.delivery_date]) - + delivery_date_list = [d.delivery_date for d in self.get("items") if d.delivery_date] + self.delivery_date = max(delivery_date_list) if delivery_date_list else None if self.delivery_date: for d in self.get("items"): if not d.delivery_date: