fix: review fixes

This commit is contained in:
Anupam 2020-10-13 12:26:25 +05:30
parent 68b069983d
commit d4e2a3324f

View File

@ -28,27 +28,22 @@ class EmailDigest(Document):
# send email only to enabled users # send email only to enabled users
valid_users = [p[0] for p in frappe.db.sql("""select name from `tabUser` valid_users = [p[0] for p in frappe.db.sql("""select name from `tabUser`
where enabled=1""")] where enabled=1""")]
recipients = frappe.db.get_list('Email Digest Recipient',
filters={
'parent': self.name
},
fields=['recipient'])
original_user = frappe.session.user original_user = frappe.session.user
if recipients: if self.recipients:
for user in recipients: for user in self.recipients:
frappe.set_user(user.recipient) if user.recipient in valid_users:
frappe.set_user_lang(user.recipient) frappe.set_user(user.recipient)
msg_for_this_recipient = self.get_msg_html() frappe.set_user_lang(user.recipient)
if msg_for_this_recipient: msg_for_this_recipient = self.get_msg_html()
frappe.sendmail( if msg_for_this_recipient:
recipients=user.recipient, frappe.sendmail(
subject=_("{0} Digest").format(self.frequency), recipients=user.recipient,
message=msg_for_this_recipient, subject=_("{0} Digest").format(self.frequency),
reference_doctype = self.doctype, message=msg_for_this_recipient,
reference_name = self.name, reference_doctype = self.doctype,
unsubscribe_message = _("Unsubscribe from this Email Digest")) reference_name = self.name,
unsubscribe_message = _("Unsubscribe from this Email Digest"))
frappe.set_user(original_user) frappe.set_user(original_user)
frappe.set_user_lang(original_user) frappe.set_user_lang(original_user)