Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Optimization for marking student attendance

Browse Source
This commit is contained in:
Nabin Hait 2018-07-27 10:51:41 +05:30
parent 0fe6ced99d
commit d0a2b1619b
2 changed files with 7 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/education/api.py
View File

@ -88,16 +88,14 @@ def make_attendance_records(student, student_name, status, course_schedule=None,
:param course_schedule: Course Schedule. :param course_schedule: Course Schedule.
:param status: Status (Present/Absent) :param status: Status (Present/Absent)
""" """
student_attendance_list = frappe.get_list("Student Attendance", fields = ['name'], filters = { student_attendance = frappe.get_doc({
"doctype": "Student Attendance",
"student": student, "student": student,
"course_schedule": course_schedule, "course_schedule": course_schedule,
"student_group": student_group, "student_group": student_group,
"date": date "date": date
}) })
if not student_attendance:
if student_attendance_list:
student_attendance = frappe.get_doc("Student Attendance", student_attendance_list[0])
else:
student_attendance = frappe.new_doc("Student Attendance") student_attendance = frappe.new_doc("Student Attendance")
student_attendance.student = student student_attendance.student = student
student_attendance.student_name = student_name student_attendance.student_name = student_name

8
erpnext/education/doctype/student_attendance/student_attendance.json
View File

@ -3,7 +3,7 @@
"allow_guest_to_view": 0, "allow_guest_to_view": 0,
"allow_import": 1, "allow_import": 1,
"allow_rename": 0, "allow_rename": 0,
"autoname": "SA.######", "autoname": "",
"beta": 0, "beta": 0,
"creation": "2015-11-05 15:20:23.045996", "creation": "2015-11-05 15:20:23.045996",
"custom": 0, "custom": 0,
@ -40,7 +40,7 @@
"remember_last_selected_value": 0, "remember_last_selected_value": 0,
"report_hide": 0, "report_hide": 0,
"reqd": 1, "reqd": 1,
"search_index": 0, "search_index": 1,
"set_only_once": 0, "set_only_once": 0,
"unique": 0 "unique": 0
}, },
@ -101,7 +101,7 @@
"remember_last_selected_value": 0, "remember_last_selected_value": 0,
"report_hide": 0, "report_hide": 0,
"reqd": 1, "reqd": 1,
"search_index": 0, "search_index": 1,
"set_only_once": 0, "set_only_once": 0,
"unique": 0 "unique": 0
}, },
@ -239,7 +239,7 @@
"issingle": 0, "issingle": 0,
"istable": 0, "istable": 0,
"max_attachments": 0, "max_attachments": 0,
"modified": "2017-11-10 19:09:51.041960", "modified": "2018-07-27 10:48:22.301531",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Education", "module": "Education",
"name": "Student Attendance", "name": "Student Attendance",