From cf99dc0e7766ccbdb0cc27664e2a5aedb734fd7f Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Thu, 9 Feb 2017 18:06:11 +0530 Subject: [PATCH] [fix] for setup wizard tests and demo; --- erpnext/demo/setup/setup_data.py | 3 +-- erpnext/setup/setup_wizard/test_setup_data.py | 3 +-- erpnext/setup/utils.py | 19 +++++++++---------- 3 files changed, 11 insertions(+), 14 deletions(-) diff --git a/erpnext/demo/setup/setup_data.py b/erpnext/demo/setup/setup_data.py index c6641012e0..4c1d443aa4 100644 --- a/erpnext/demo/setup/setup_data.py +++ b/erpnext/demo/setup/setup_data.py @@ -46,8 +46,7 @@ def complete_setup(domain='Manufacturing'): if not frappe.get_all('Company', limit=1): setup_complete({ - "first_name": "Test", - "last_name": "User", + "full_name": "Test User", "email": "test_demo@erpnext.com", "company_tagline": 'Awesome Products and Services', "password": "demo", diff --git a/erpnext/setup/setup_wizard/test_setup_data.py b/erpnext/setup/setup_wizard/test_setup_data.py index de54a1d16b..25378f4ab5 100644 --- a/erpnext/setup/setup_wizard/test_setup_data.py +++ b/erpnext/setup/setup_wizard/test_setup_data.py @@ -13,7 +13,7 @@ args = { "customer_2": "Mahesh Engg", "customer_contact_1": "Aditya Duggal", "customer_contact_2": "Mahesh Malani", -"first_name": "Rushabh", +"full_name": "Rushabh Mehta", "fy_start": "1st Apr", "item_1": "Enterprise Plan", "item_2": "Small Business", @@ -42,7 +42,6 @@ args = { "item_uom_3": "Unit", "item_uom_4": "Unit", "item_uom_5": "Unit", -"last_name": "Mehta", "supplier_1": "Google", "supplier_2": "Hetzner", "supplier_3": "Digital Ocean", diff --git a/erpnext/setup/utils.py b/erpnext/setup/utils.py index 0c214e4c2a..cb638373b1 100644 --- a/erpnext/setup/utils.py +++ b/erpnext/setup/utils.py @@ -6,7 +6,7 @@ import frappe from frappe import _, throw from frappe.utils import flt from frappe.utils import get_datetime_str, nowdate - + def get_company_currency(company): currency = frappe.db.get_value("Company", company, "default_currency", cache=True) if not currency: @@ -37,8 +37,7 @@ def before_tests(): if not frappe.get_list("Company"): setup_complete({ "currency" :"USD", - "first_name" :"Test", - "last_name" :"User", + "full_name" :"Test User", "company_name" :"Wind Power LLC", "timezone" :"America/New_York", "company_abbr" :"WP", @@ -52,7 +51,7 @@ def before_tests(): "password" :"test", "chart_of_accounts" : "Standard", "domain" : "Manufacturing", - + }) frappe.db.sql("delete from `tabLeave Allocation`") @@ -71,18 +70,18 @@ def get_exchange_rate(from_currency, to_currency, transaction_date=None): if not (from_currency and to_currency): # manqala 19/09/2016: Should this be an empty return or should it throw and exception? return - + if from_currency == to_currency: return 1 - + # cksgb 19/09/2016: get last entry in Currency Exchange with from_currency and to_currency. - entries = frappe.get_all("Currency Exchange", fields = ["exchange_rate"], + entries = frappe.get_all("Currency Exchange", fields = ["exchange_rate"], filters=[ - ["date", "<=", get_datetime_str(transaction_date)], - ["from_currency", "=", from_currency], + ["date", "<=", get_datetime_str(transaction_date)], + ["from_currency", "=", from_currency], ["to_currency", "=", to_currency] ], order_by="date desc", limit=1) - + if entries: return flt(entries[0].exchange_rate)