Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(ui): better message after creating serial numbers (#18093)

Browse Source 
fix(ui): better message after creating serial numbers
This commit is contained in:
Aditya Hase 2019-06-27 18:20:13 +05:30 committed by GitHub
commit ce9cdfb056
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/doctype/serial_no/serial_no.py
View File

@ -352,6 +352,7 @@ def get_auto_serial_nos(serial_no_series, qty):
def auto_make_serial_nos(args):
serial_nos = get_serial_nos(args.get('serial_no'))
created_numbers = []
for serial_no in serial_nos:
if frappe.db.exists("Serial No", serial_no):
sr = frappe.get_doc("Serial No", serial_no)
@ -366,7 +367,12 @@ def auto_make_serial_nos(args):
sr.sales_order = None
sr.save(ignore_permissions=True)
elif args.get('actual_qty', 0) > 0:
make_serial_no(serial_no, args)
created_numbers.append(make_serial_no(serial_no, args))
if len(created_numbers) == 1:
frappe.msgprint(_("Serial No {0} created").format(created_numbers[0]))
elif len(created_numbers) > 0:
frappe.msgprint(_("The following serial numbers were created: <br> {0}").format(', '.join(created_numbers)))
def get_item_details(item_code):
return frappe.db.sql("""select name, has_batch_no, docstatus,
@ -399,7 +405,6 @@ def make_serial_no(serial_no, args):
sr.warehouse = args.get('warehouse')
sr.save()
frappe.msgprint(_("Serial No {0} created").format(sr.name))
return sr.name
def update_serial_nos_after_submit(controller, parentfield):