Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: use enumerate instead of trackign index

Browse Source 
also removed dead code
This commit is contained in:
Ankush Menat 2021-05-22 23:52:00 +05:30
parent 44c489223b
commit ccbde0efa0
No known key found for this signature in database
GPG Key ID: 8EA82E09BBD13AAF
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/stock/doctype/item/item.py
View File

@ -72,8 +72,6 @@ class Item(WebsiteGenerator):
if not self.description: if not self.description:
self.description = self.item_name self.description = self.item_name
# if self.is_sales_item and not self.get('is_item_from_hub'):
# self.publish_in_hub = 1
def after_insert(self): def after_insert(self):
'''set opening stock and item price''' '''set opening stock and item price'''
@ -1277,14 +1275,13 @@ def get_item_attribute(parent, attribute_value=''):
filters = {'parent': parent, 'attribute_value': ("like", "%%%s%%" % attribute_value)}) filters = {'parent': parent, 'attribute_value': ("like", "%%%s%%" % attribute_value)})
def update_variants(variants, template, publish_progress=True): def update_variants(variants, template, publish_progress=True):
count=0 total = len(variants)
for d in variants: for count, d in enumerate(variants, start=1):
variant = frappe.get_doc("Item", d) variant = frappe.get_doc("Item", d)
copy_attributes_to_variant(template, variant) copy_attributes_to_variant(template, variant)
variant.save() variant.save()
count+=1
if publish_progress: if publish_progress:
frappe.publish_progress(count*100/len(variants), title = _("Updating Variants...")) frappe.publish_progress(count / total * 100, title=_("Updating Variants..."))
def on_doctype_update(): def on_doctype_update():
# since route is a Text column, it needs a length for indexing # since route is a Text column, it needs a length for indexing