Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: remove sla if no active sla found

Browse Source
This commit is contained in:
Saqib Ansari 2022-01-14 18:17:40 +05:30
parent b31679b6ef
commit cc88b31f1f
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
View File

@ -385,7 +385,7 @@ def apply(doc, method=None):
sla = get_active_service_level_agreement_for(doc) sla = get_active_service_level_agreement_for(doc)
if not sla: if not sla:
remove_sla_if_applied() remove_sla_if_applied(doc)
return return
process_sla(doc, sla) process_sla(doc, sla)

7
erpnext/support/doctype/service_level_agreement/test_service_level_agreement.py
View File

@ -244,6 +244,13 @@ class TestServiceLevelAgreement(unittest.TestCase):
applied_sla = frappe.db.get_value('Lead', lead.name, 'service_level_agreement') applied_sla = frappe.db.get_value('Lead', lead.name, 'service_level_agreement')
self.assertEqual(applied_sla, lead_sla.name) self.assertEqual(applied_sla, lead_sla.name)
# check if SLA is removed if condition fails
lead.reload()
lead.source = None
lead.save()
applied_sla = frappe.db.get_value('Lead', lead.name, 'service_level_agreement')
self.assertFalse(applied_sla)
def tearDown(self): def tearDown(self):
for d in frappe.get_all("Service Level Agreement"): for d in frappe.get_all("Service Level Agreement"):
frappe.delete_doc("Service Level Agreement", d.name, force=1) frappe.delete_doc("Service Level Agreement", d.name, force=1)