Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: multiple SCO against a PO

Browse Source
This commit is contained in:
Sagar Sharma 2022-07-02 06:20:09 +05:30
parent fd162f9b14
commit caeaa3f940
2 changed files with 18 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
erpnext/buying/doctype/purchase_order/purchase_order.py
View File

@ -691,3 +691,12 @@ def get_mapped_subcontracting_order(source_name, target_doc=None):
item.warehouse = source_doc.items[idx].warehouse item.warehouse = source_doc.items[idx].warehouse
return target_doc return target_doc
@frappe.whitelist()
def is_subcontracting_order_created(po_name) -> bool:
count = frappe.db.count(
"Subcontracting Order", {"purchase_order": po_name, "status": ["not in", ["Draft", "Cancelled"]]}
)
return True if count else False

9
erpnext/subcontracting/doctype/subcontracting_order/subcontracting_order.py
View File

@ -6,6 +6,7 @@ from frappe import _
from frappe.model.mapper import get_mapped_doc from frappe.model.mapper import get_mapped_doc
from frappe.utils import flt from frappe.utils import flt
from erpnext.buying.doctype.purchase_order.purchase_order import is_subcontracting_order_created
from erpnext.controllers.subcontracting_controller import SubcontractingController from erpnext.controllers.subcontracting_controller import SubcontractingController
from erpnext.stock.stock_balance import get_ordered_qty, update_bin_qty from erpnext.stock.stock_balance import get_ordered_qty, update_bin_qty
from erpnext.stock.utils import get_bin from erpnext.stock.utils import get_bin
@ -36,7 +37,15 @@ class SubcontractingOrder(SubcontractingController):
def validate_purchase_order_for_subcontracting(self): def validate_purchase_order_for_subcontracting(self):
if self.purchase_order: if self.purchase_order:
if is_subcontracting_order_created(self.purchase_order):
frappe.throw(
_(
"Only one Subcontracting Order can be created against a Purchase Order, cancel the existing Subcontracting Order to create a new one."
)
)
po = frappe.get_doc("Purchase Order", self.purchase_order) po = frappe.get_doc("Purchase Order", self.purchase_order)
if not po.is_subcontracted: if not po.is_subcontracted:
frappe.throw(_("Please select a valid Purchase Order that is configured for Subcontracting.")) frappe.throw(_("Please select a valid Purchase Order that is configured for Subcontracting."))