Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #25255 from nextchamp-saqib/issue-condition-fix

Browse Source 
fix: condition for setting agreement status
This commit is contained in:
Deepesh Garg 2021-04-09 21:40:14 +05:30 committed by GitHub
commit c85c243f9c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
erpnext/support/doctype/issue/issue.py
View File

@ -7,7 +7,7 @@ import json
from frappe import _ from frappe import _
from frappe import utils from frappe import utils
from frappe.model.document import Document from frappe.model.document import Document
from frappe.utils import now_datetime, getdate, get_weekdays, add_to_date, get_time, get_datetime, time_diff_in_seconds from frappe.utils import cint, now_datetime, getdate, get_weekdays, add_to_date, get_time, get_datetime, time_diff_in_seconds
from datetime import datetime, timedelta from datetime import datetime, timedelta
from frappe.model.mapper import get_mapped_doc from frappe.model.mapper import get_mapped_doc
from frappe.utils.user import is_website_user from frappe.utils.user import is_website_user
@ -128,8 +128,8 @@ class Issue(Document):
def update_agreement_status(self): def update_agreement_status(self):
if self.service_level_agreement and self.agreement_status == "Ongoing": if self.service_level_agreement and self.agreement_status == "Ongoing":
if frappe.db.get_value("Issue", self.name, "response_by_variance") < 0 or \ if cint(frappe.db.get_value("Issue", self.name, "response_by_variance")) < 0 or \
frappe.db.get_value("Issue", self.name, "resolution_by_variance") < 0: cint(frappe.db.get_value("Issue", self.name, "resolution_by_variance")) < 0:
self.agreement_status = "Failed" self.agreement_status = "Failed"
else: else: