From c77c296b8b3873e87124a2aa3f2b33105ffb62ba Mon Sep 17 00:00:00 2001 From: Gursheen Anand Date: Thu, 12 Oct 2023 13:10:59 +0530 Subject: [PATCH] feat: validate before allowing repost --- erpnext/accounts/doctype/journal_entry/journal_entry.py | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/erpnext/accounts/doctype/journal_entry/journal_entry.py b/erpnext/accounts/doctype/journal_entry/journal_entry.py index 1d02e025fc..14ec795e2e 100644 --- a/erpnext/accounts/doctype/journal_entry/journal_entry.py +++ b/erpnext/accounts/doctype/journal_entry/journal_entry.py @@ -77,6 +77,13 @@ class JournalEntry(AccountsController): if not self.title: self.title = self.get_title() + def validate_for_repost(self): + self.validate_party() + self.validate_multi_currency() + if not frappe.flags.is_reverse_depr_entry: + self.validate_against_jv() + self.validate_stock_accounts() + def on_submit(self): self.validate_cheque_info() self.check_credit_limit() @@ -90,6 +97,7 @@ class JournalEntry(AccountsController): if hasattr(self, "repost_required"): child_tables = {"accounts": ("account", "account_type", "bank_account")} self.needs_repost = self.check_if_fields_updated([], child_tables) + self.validate_for_repost() self.db_set("repost_required", self.needs_repost) def on_cancel(self):