From c5629efe0e499b1185fb3d2cbd265a4136d23d89 Mon Sep 17 00:00:00 2001 From: Jamsheer Date: Tue, 22 May 2018 16:18:43 +0530 Subject: [PATCH] Employee Benefit Application - refactor validation --- .../employee_benefit_application.py | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py b/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py index 56b711bccc..05725d6d7d 100644 --- a/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py +++ b/erpnext/hr/doctype/employee_benefit_application/employee_benefit_application.py @@ -12,13 +12,11 @@ from frappe.desk.reportview import get_match_cond class EmployeeBenefitApplication(Document): def validate(self): + self.validate_duplicate_on_payroll_period() if self.max_benefits <= 0: frappe.throw(_("Employee {0} has no maximum benefit amount").format(self.employee)) self.validate_max_benefit_for_component() - def before_submit(self): - self.validate_duplicate_on_payroll_period() - def validate_max_benefit_for_component(self): if self.employee_benefits: max_benefit_amount = 0