From c541b87bb92c4dae6c3222b551b68d22ff0ac886 Mon Sep 17 00:00:00 2001 From: Rushabh Mehta Date: Thu, 5 Nov 2015 10:49:42 +0530 Subject: [PATCH] [thumbnail] remove attachment if fails --- erpnext/stock/doctype/item/item.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/erpnext/stock/doctype/item/item.py b/erpnext/stock/doctype/item/item.py index 1d8184559f..168d999dcc 100644 --- a/erpnext/stock/doctype/item/item.py +++ b/erpnext/stock/doctype/item/item.py @@ -85,6 +85,8 @@ class Item(WebsiteGenerator): def make_thumbnail(self): """Make a thumbnail of `website_image`""" + import requests.exceptions + if not self.is_new() and self.website_image != frappe.db.get_value(self.doctype, self.name, "website_image"): self.thumbnail = None @@ -102,8 +104,12 @@ class Item(WebsiteGenerator): # cleanup frappe.local.message_log.pop() + except requests.exceptions.HTTPError: + frappe.msgprint(_("Warning: Invalid Attachment {0}").format(self.website_image)) + self.website_image = None + # for CSV import - if not file_doc: + if self.website_image and not file_doc: try: file_doc = frappe.get_doc({ "doctype": "File",