Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: validation for existing bundles

Browse Source 
(cherry picked from commit 67f43d37df9e77c3e59562117fa44ea76273a536)
This commit is contained in:
Gursheen Anand 2023-11-22 16:10:49 +05:30 committed by Mergify
parent 5c12872f70
commit c0de9c0cef
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/selling/doctype/product_bundle/product_bundle.py
View File

@ -64,7 +64,7 @@ class ProductBundle(Document):
def validate_child_items(self):
for item in self.items:
if frappe.db.exists("Product Bundle", item.item_code):
if frappe.db.exists("Product Bundle", {"name": item.item_code, "disabled": 0}):
frappe.throw(
_(
"Row #{0}: Child Item should not be a Product Bundle. Please remove Item {1} and Save"
@ -75,7 +75,7 @@ class ProductBundle(Document):
@frappe.whitelist()
@frappe.validate_and_sanitize_search_inputs
def get_new_item_code(doctype, txt, searchfield, start, page_len, filters):
product_bundles = frappe.db.get_list("Product Bundle", pluck="name")
product_bundles = frappe.db.get_list("Product Bundle", {"disabled": 0}, pluck="name")
item = frappe.qb.DocType("Item")
return (
frappe.qb.from_(item)