Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: convert goals point to flt (#21844)

Browse Source
This commit is contained in:
Anurag Mishra 2020-05-21 18:47:39 +05:30 committed by GitHub
parent 82523a5487
commit c07265ea3f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/hr/doctype/appraisal_template/appraisal_template.py
View File

@ -3,7 +3,7 @@
from __future__ import unicode_literals from __future__ import unicode_literals
import frappe import frappe
from frappe.utils import cint from frappe.utils import cint, flt
from frappe import _ from frappe import _
from frappe.model.document import Document from frappe.model.document import Document
@ -11,11 +11,11 @@ from frappe.model.document import Document
class AppraisalTemplate(Document): class AppraisalTemplate(Document):
def validate(self): def validate(self):
self.check_total_points() self.check_total_points()
def check_total_points(self): def check_total_points(self):
total_points = 0 total_points = 0
for d in self.get("goals"): for d in self.get("goals"):
total_points += int(d.per_weightage or 0) total_points += flt(d.per_weightage)
if cint(total_points) != 100: if cint(total_points) != 100:
frappe.throw(_("Sum of points for all goals should be 100. It is {0}").format(total_points)) frappe.throw(_("Sum of points for all goals should be 100. It is {0}").format(total_points))