Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Clear Payment Schedule if PI has default Payment Schedule, but linked PO doensn't

Browse Source
This commit is contained in:
GangaManoj 2021-07-09 01:44:34 +05:30
parent 5a62467a3e
commit bf245e5e39
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
View File

@ -1180,10 +1180,14 @@ def set_payment_terms_from_po(doc):
purchase_order = doc.get('items')[0].get('purchase_order') purchase_order = doc.get('items')[0].get('purchase_order')
if linked_po_has_payment_terms(doc, purchase_order) and all_items_have_same_po(doc, purchase_order): if purchase_order and all_items_have_same_po(doc, purchase_order):
purchase_order = frappe.get_cached_doc('Purchase Order', purchase_order) purchase_order = frappe.get_cached_doc('Purchase Order', purchase_order)
else:
return
if has_default_payment_terms(doc) and not has_default_payment_terms(purchase_order):
doc['payment_schedule'] = []
doc['payment_terms_template'] = purchase_order.payment_terms_template doc['payment_terms_template'] = purchase_order.payment_terms_template
doc['terms'] = purchase_order.payment_terms_template
for schedule in purchase_order.payment_schedule: for schedule in purchase_order.payment_schedule:
payment_schedule = { payment_schedule = {
@ -1200,9 +1204,6 @@ def set_payment_terms_from_po(doc):
return doc return doc
def linked_po_has_payment_terms(doc, purchase_order):
return not doc.get('payment_schedule') and purchase_order
def all_items_have_same_po(doc, purchase_order): def all_items_have_same_po(doc, purchase_order):
for item in doc.get('items'): for item in doc.get('items'):
if item.get('purchase_order') != purchase_order: if item.get('purchase_order') != purchase_order:
@ -1210,6 +1211,11 @@ def all_items_have_same_po(doc, purchase_order):
return True return True
def has_default_payment_terms(doc):
if doc.get('payment_schedule')[0].get('invoice_portion') == 100:
return True
return False
# to get details of purchase invoice/receipt from which this doc was created for exchange rate difference handling # to get details of purchase invoice/receipt from which this doc was created for exchange rate difference handling
def get_purchase_document_details(doc): def get_purchase_document_details(doc):
if doc.doctype == 'Purchase Invoice': if doc.doctype == 'Purchase Invoice':