Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Use db_set since it triggers on_update event (#18175)

Browse Source
This commit is contained in:
Suraj Shetty 2019-07-08 10:30:26 +05:30 committed by Nabin Hait
parent d86f027ce0
commit bef897602d
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/doctype/bank_reconciliation/bank_reconciliation.py
View File

@ -103,7 +103,7 @@ class BankReconciliation(Document):
for d in self.get('payment_entries'): for d in self.get('payment_entries'):
if d.clearance_date: if d.clearance_date:
if not d.payment_document: if not d.payment_document:
frappe.throw(_("Row #{0}: Payment document is required to complete the trasaction")) frappe.throw(_("Row #{0}: Payment document is required to complete the transaction"))
if d.cheque_date and getdate(d.clearance_date) < getdate(d.cheque_date): if d.cheque_date and getdate(d.clearance_date) < getdate(d.cheque_date):
frappe.throw(_("Row #{0}: Clearance date {1} cannot be before Cheque Date {2}") frappe.throw(_("Row #{0}: Clearance date {1} cannot be before Cheque Date {2}")
@ -113,10 +113,8 @@ class BankReconciliation(Document):
if not d.clearance_date: if not d.clearance_date:
d.clearance_date = None d.clearance_date = None
frappe.db.set_value(d.payment_document, d.payment_entry, "clearance_date", d.clearance_date) payment_entry = frappe.get_doc(d.payment_document, d.payment_entry)
frappe.db.sql("""update `tab{0}` set clearance_date = %s, modified = %s payment_entry.db_set('clearance_date', d.clearance_date)
where name=%s""".format(d.payment_document),
(d.clearance_date, nowdate(), d.payment_entry))
clearance_date_updated = True clearance_date_updated = True