From bd6a4ca1d7f419f8b0c766c5b7aae0f3513ebc22 Mon Sep 17 00:00:00 2001 From: David Arnold Date: Mon, 22 Jan 2024 22:54:36 +0100 Subject: [PATCH] fix: move value initialization to ensure it is commited --- erpnext/buying/doctype/purchase_order/purchase_order.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/erpnext/buying/doctype/purchase_order/purchase_order.py b/erpnext/buying/doctype/purchase_order/purchase_order.py index fcdc87de1c..4efbb270e9 100644 --- a/erpnext/buying/doctype/purchase_order/purchase_order.py +++ b/erpnext/buying/doctype/purchase_order/purchase_order.py @@ -215,6 +215,10 @@ class PurchaseOrder(BuyingController): self.validate_fg_item_for_subcontracting() self.set_received_qty_for_drop_ship_items() + + if not self.advance_payment_status: + self.advance_payment_status = "Not Initiated" + validate_inter_company_party( self.doctype, self.supplier, self.company, self.inter_company_order_reference ) @@ -470,9 +474,6 @@ class PurchaseOrder(BuyingController): self.validate_budget() self.update_reserved_qty_for_subcontract() - if not self.advance_payment_status: - self.advance_payment_status = "Not Initiated" - frappe.get_doc("Authorization Control").validate_approving_authority( self.doctype, self.company, self.base_grand_total )