Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[Fix]Codacy Issues

Browse Source
This commit is contained in:
Brown-Harry Boma 2017-10-23 10:04:00 +01:00 committed by Nabin Hait
parent 2da8f6e89d
commit b9e44217a2
1 changed files with 8 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/stock/report/stock_balance/stock_balance.py
View File

@ -43,7 +43,7 @@ def execute(filters=None):
if filters.get('show_variants',0) == 1: if filters.get('show_variants',0) == 1:
variants_attributes = get_variants_attributes() variants_attributes = get_variants_attributes()
report_data += [item_map[item][i] for i in variants_attributes] report_data += [item_map[item][i] for i in variants_attributes]
data.append(report_data) data.append(report_data)
if filters.get('show_variants',0) == 1: if filters.get('show_variants',0) == 1:
@ -232,13 +232,11 @@ def get_variants_attributes():
def get_variant_values_for_(items): def get_variant_values_for_(items):
'''Returns variant values for items.''' '''Returns variant values for items.'''
attribute_map = {} attribute_map = {}
for attr in frappe.db.sql('''select parent, attribute, attribute_value for attr in frappe.db.sql('''select parent, attribute,
from attribute_value from `tabItem Variant Attribute`
`tabItem Variant Attribute` where parent in (%s);
where parent in (%s);''' %", ".join(["%s"]*len(items)), ''' % ", ".join(["%s"] * len(items)), tuple(items), as_dict=1):
tuple(items), attribute_map.setdefault(attr['parent'], {})
as_dict=1):
attribute_map.setdefault(attr['parent'],{})
attribute_map[attr['parent']].update({attr['attribute']:attr['attribute_value']}) attribute_map[attr['parent']].update({attr['attribute']:attr['attribute_value']})
return attribute_map return attribute_map