Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: moved purpose table mandatory check to server

Browse Source
This commit is contained in:
Noah Jacob 2021-12-17 13:46:46 +05:30
parent 90d32006f4
commit b98c61f2a7
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.js
View File

@ -41,7 +41,6 @@ frappe.ui.form.on('Maintenance Visit', {
frm.set_value({ status: 'Draft' }); frm.set_value({ status: 'Draft' });
} }
if (frm.doc.__islocal) { if (frm.doc.__islocal) {
frm.doc.maintenance_type == 'Unscheduled' && frm.clear_table("purposes");
frm.set_value({ mntc_date: frappe.datetime.get_today() }); frm.set_value({ mntc_date: frappe.datetime.get_today() });
} }
}, },

6
erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.json
View File

@ -179,8 +179,7 @@
"label": "Purposes", "label": "Purposes",
"oldfieldname": "maintenance_visit_details", "oldfieldname": "maintenance_visit_details",
"oldfieldtype": "Table", "oldfieldtype": "Table",
"options": "Maintenance Visit Purpose", "options": "Maintenance Visit Purpose"
"reqd": 1
}, },
{ {
"fieldname": "more_info", "fieldname": "more_info",
@ -294,10 +293,11 @@
"idx": 1, "idx": 1,
"is_submittable": 1, "is_submittable": 1,
"links": [], "links": [],
"modified": "2021-05-27 16:06:17.352572", "modified": "2021-12-17 03:10:27.608112",
"modified_by": "Administrator", "modified_by": "Administrator",
"module": "Maintenance", "module": "Maintenance",
"name": "Maintenance Visit", "name": "Maintenance Visit",
"naming_rule": "By \"Naming Series\" field",
"owner": "Administrator", "owner": "Administrator",
"permissions": [ "permissions": [
{ {

5
erpnext/maintenance/doctype/maintenance_visit/maintenance_visit.py
View File

@ -18,6 +18,10 @@ class MaintenanceVisit(TransactionBase):
if d.serial_no and not frappe.db.exists("Serial No", d.serial_no): if d.serial_no and not frappe.db.exists("Serial No", d.serial_no):
frappe.throw(_("Serial No {0} does not exist").format(d.serial_no)) frappe.throw(_("Serial No {0} does not exist").format(d.serial_no))
def validate_purpose_table(self):
if not self.purposes:
frappe.throw(_("Add Items in the Purpose Table"), title="Purposes Required")
def validate_maintenance_date(self): def validate_maintenance_date(self):
if self.maintenance_type == "Scheduled" and self.maintenance_schedule_detail: if self.maintenance_type == "Scheduled" and self.maintenance_schedule_detail:
item_ref = frappe.db.get_value('Maintenance Schedule Detail', self.maintenance_schedule_detail, 'item_reference') item_ref = frappe.db.get_value('Maintenance Schedule Detail', self.maintenance_schedule_detail, 'item_reference')
@ -29,6 +33,7 @@ class MaintenanceVisit(TransactionBase):
def validate(self): def validate(self):
self.validate_serial_no() self.validate_serial_no()
self.validate_maintenance_date() self.validate_maintenance_date()
self.validate_purpose_table()
def update_completion_status(self): def update_completion_status(self):
if self.maintenance_schedule_detail: if self.maintenance_schedule_detail: