Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Skip unpublished Variants with published templates in shopping cart quote validation

Browse Source
This commit is contained in:
marination 2022-04-19 13:00:00 +05:30
parent 53d8168dea
commit b848e61954
1 changed files with 14 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/selling/doctype/quotation/quotation.py
View File

@ -55,8 +55,20 @@ class Quotation(SellingController):
return return
for item in self.items: for item in self.items:
if not frappe.db.exists("Website Item", {"item_code": item.item_code}): has_web_item = frappe.db.exists("Website Item", {"item_code": item.item_code})
frappe.throw(_("Item {0} must be a website item for Shopping Cart quotations").format(item.item_code))
# If variant is unpublished but template is published: valid
template = frappe.get_cached_value("Item", item.item_code, "variant_of")
if template and not has_web_item:
has_web_item = frappe.db.exists("Website Item", {"item_code": template})
if not has_web_item:
frappe.throw(
_(
"Row #{0}: Item {1} must have a Website Item for Shopping Cart Quotations"
).format(item.idx, frappe.bold(item.item_code)),
title=_("Unpublished Item")
)
def has_sales_order(self): def has_sales_order(self):
return frappe.db.get_value("Sales Order Item", {"prevdoc_docname": self.name, "docstatus": 1}) return frappe.db.get_value("Sales Order Item", {"prevdoc_docname": self.name, "docstatus": 1})