Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: don't refresh connections for same node

Browse Source 
- remove all connectors while expanding a group node
This commit is contained in:
Rucha Mahabal 2021-06-29 18:21:42 +05:30
parent f5314293c6
commit b7c61ff651
1 changed files with 10 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
erpnext/hr/page/organizational_chart/organizational_chart.js
View File

@ -573,6 +573,7 @@ class OrgChartMobile {
} }
expand_node(node) { expand_node(node) {
const is_same_node = (this.selected_node && this.selected_node.id === node.id);
this.set_selected_node(node); this.set_selected_node(node);
this.show_active_path(node); this.show_active_path(node);
@ -582,13 +583,15 @@ class OrgChartMobile {
this.$sibling_group.empty(); this.$sibling_group.empty();
} }
// since the previous/parent node collapses, all connections to that node need to be rebuilt if (!is_same_node) {
// rebuild outgoing connections of parent // since the previous/parent node collapses, all connections to that node need to be rebuilt
this.refresh_connectors(node.parent_id, node.id); // rebuild outgoing connections of parent
this.refresh_connectors(node.parent_id, node.id);
// rebuild incoming connections of parent // rebuild incoming connections of parent
let grandparent = $(`#${node.parent_id}`).attr('data-parent'); let grandparent = $(`#${node.parent_id}`).attr('data-parent');
this.refresh_connectors(grandparent, node.parent_id); this.refresh_connectors(grandparent, node.parent_id);
}
if (node.expandable && !node.expanded) { if (node.expandable && !node.expanded) {
return this.load_children(node); return this.load_children(node);
@ -884,6 +887,7 @@ class OrgChartMobile {
<li class="level"></li> <li class="level"></li>
`); `);
this.$hierarchy.find('.level').append(node); this.$hierarchy.find('.level').append(node);
$(`#connectors`).empty();
this.expand_node(node_object); this.expand_node(node_object);
} }
]); ]);