Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

style: change type comparison for boolean expression

Browse Source
This commit is contained in:
Mangesh-Khairnar 2019-04-09 12:26:52 +05:30
parent 16c4fd6733
commit b70b048fa2
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
erpnext/selling/doctype/sales_order/sales_order.js
View File

@ -33,7 +33,7 @@ frappe.ui.form.on("Sales Order", {
})
},
refresh: function(frm) {
if(frm.doc.docstatus == 1 && frm.doc.status != 'Closed'
if(frm.doc.docstatus === 1 && frm.doc.status !== 'Closed'
&& flt(frm.doc.per_delivered) < 100 && flt(frm.doc.per_billed) < 100) {
frm.add_custom_button(__('Update Items'), () => {
erpnext.utils.update_child_items({
@ -135,8 +135,8 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend(
}, __("Status"));
}
}
if(doc.status != 'Closed') {
if(doc.status != 'On Hold') {
if(doc.status !== 'Closed') {
if(doc.status !== 'On Hold') {
for (var i in this.frm.doc.items) {
var item = this.frm.doc.items[i];
if(item.delivered_by_supplier === 1 || item.supplier){
@ -161,8 +161,8 @@ erpnext.selling.SalesOrderController = erpnext.selling.SellingController.extend(
if(flt(doc.per_delivered, 6) < 100 || flt(doc.per_billed) < 100) {
// hold
this.frm.add_custom_button(__('Hold'),
function() {
me.hold_sales_order();
function() {
me.hold_sales_order();
}, __("Status"))
// close
this.frm.add_custom_button(__('Close'),