From b58b1343bb80f3442f49728e965f834a35d2f257 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Mon, 28 Mar 2022 10:19:22 +0530 Subject: [PATCH] refactor: dont harcode "serial_no" field --- erpnext/public/js/utils/barcode_scanner.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/erpnext/public/js/utils/barcode_scanner.js b/erpnext/public/js/utils/barcode_scanner.js index c6c3938eb4..abea5fcb20 100644 --- a/erpnext/public/js/utils/barcode_scanner.js +++ b/erpnext/public/js/utils/barcode_scanner.js @@ -145,7 +145,8 @@ erpnext.utils.BarcodeScanner = class BarcodeScanner { } is_duplicate_serial_no(row, serial_no) { - const is_duplicate = !!serial_no && !!row.serial_no && row.serial_no.includes(serial_no); + const is_duplicate = !!serial_no && !!row[this.serial_no_field] + && row[this.serial_no_field].includes(serial_no); if (is_duplicate) { frappe.show_alert(