From afc5a55a2308214e9c4a4ced94b99bfc5bcd8ec5 Mon Sep 17 00:00:00 2001 From: Ankush Menat Date: Sun, 17 Apr 2022 19:20:05 +0530 Subject: [PATCH] refactor: repost error handling --- .../doctype/repost_item_valuation/repost_item_valuation.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py index c7d65c6bde..49aa0ff72f 100644 --- a/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py +++ b/erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py @@ -6,7 +6,6 @@ from frappe import _ from frappe.model.document import Document from frappe.utils import cint, get_link_to_form, get_weekday, now, nowtime from frappe.utils.user import get_users_with_role -from rq.timeouts import JobTimeoutException import erpnext from erpnext.accounts.utils import update_gl_entries_after @@ -129,12 +128,12 @@ def repost(doc): doc.set_status("Completed") - except (Exception, JobTimeoutException): + except Exception: frappe.db.rollback() traceback = frappe.get_traceback() frappe.log_error(traceback) - message = frappe.message_log.pop() + message = frappe.message_log.pop() if frappe.message_log else "" if traceback: message += "
" + "Traceback:
" + traceback frappe.db.set_value(doc.doctype, doc.name, "error_log", message)