Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: block cancellation of SL/GL entries (#30652)

Browse Source 
Individual GL/SLEs aren't supposed to be cancelled by users.
This commit is contained in:
Ankush Menat 2022-04-08 18:05:04 +05:30 committed by GitHub
parent fcbd25f27a
commit af6b07f9b9
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 12 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/doctype/gl_entry/gl_entry.js
View File

@ -3,6 +3,6 @@
frappe.ui.form.on('GL Entry', { frappe.ui.form.on('GL Entry', {
refresh: function(frm) { refresh: function(frm) {
frm.page.btn_secondary.hide()
} }
}); });

5
erpnext/accounts/doctype/gl_entry/gl_entry.py
View File

@ -269,6 +269,11 @@ class GLEntry(Document):
if not self.fiscal_year: if not self.fiscal_year:
self.fiscal_year = get_fiscal_year(self.posting_date, company=self.company)[0] self.fiscal_year = get_fiscal_year(self.posting_date, company=self.company)[0]
def on_cancel(self):
msg = _("Individual GL Entry cannot be cancelled.")
msg += "<br>" + _("Please cancel related transaction.")
frappe.throw(msg)
def validate_balance_type(account, adv_adj=False): def validate_balance_type(account, adv_adj=False):
if not adv_adj and account: if not adv_adj and account:

2
erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.js
View File

@ -3,6 +3,6 @@
frappe.ui.form.on('Stock Ledger Entry', { frappe.ui.form.on('Stock Ledger Entry', {
refresh: function(frm) { refresh: function(frm) {
frm.page.btn_secondary.hide()
} }
}); });

5
erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.py
View File

@ -209,6 +209,11 @@ class StockLedgerEntry(Document):
msg += "<br>" + "<br>".join(authorized_users) msg += "<br>" + "<br>".join(authorized_users)
frappe.throw(msg, BackDatedStockTransaction, title=_("Backdated Stock Entry")) frappe.throw(msg, BackDatedStockTransaction, title=_("Backdated Stock Entry"))
def on_cancel(self):
msg = _("Individual Stock Ledger Entry cannot be cancelled.")
msg += "<br>" + _("Please cancel related transaction.")
frappe.throw(msg)
def on_doctype_update(): def on_doctype_update():
if not frappe.db.has_index("tabStock Ledger Entry", "posting_sort_index"): if not frappe.db.has_index("tabStock Ledger Entry", "posting_sort_index"):