Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

test: assert balanaces against SLE

Browse Source
This commit is contained in:
Ankush Menat 2022-04-11 15:16:19 +05:30
parent f4766ae4eb
commit af0ea7b532
1 changed files with 31 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
erpnext/stock/report/stock_balance/test_stock_balance.py
View File

@ -23,7 +23,7 @@ class TestStockBalance(FrappeTestCase):
{ {
"company": "_Test Company", "company": "_Test Company",
"item_code": self.item.name, "item_code": self.item.name,
"from_date": str(today()), "from_date": "2020-01-01",
"to_date": str(today()), "to_date": str(today()),
} }
) )
@ -44,7 +44,27 @@ class TestStockBalance(FrappeTestCase):
to_warehouse=movement.to_warehouse or "_Test Warehouse - _TC", to_warehouse=movement.to_warehouse or "_Test Warehouse - _TC",
) )
def assertBasicInvariants(self, rows): def assertInvariants(self, rows):
last_balance = frappe.db.sql(
"""
WITH last_balances AS (
SELECT item_code, warehouse,
stock_value, qty_after_transaction,
ROW_NUMBER() OVER (PARTITION BY item_code, warehouse
ORDER BY timestamp(posting_date, posting_time) desc, creation desc)
AS rn
FROM `tabStock Ledger Entry`
where is_cancelled=0
)
SELECT * FROM last_balances WHERE rn = 1""",
as_dict=True,
)
item_wh_stock = _dict()
for line in last_balance:
item_wh_stock.setdefault((line.item_code, line.warehouse), line)
for row in rows: for row in rows:
msg = f"Invariants not met for {rows=}" msg = f"Invariants not met for {rows=}"
# qty invariant # qty invariant
@ -56,6 +76,11 @@ class TestStockBalance(FrappeTestCase):
# valuation rate # valuation rate
self.assertAlmostEqual(row.val_rate, row.bal_val / row.bal_qty, 3, msg) self.assertAlmostEqual(row.val_rate, row.bal_val / row.bal_qty, 3, msg)
# check against SLE
last_sle = item_wh_stock[(row.item_code, row.warehouse)]
self.assertAlmostEqual(row.bal_qty, last_sle.qty_after_transaction, 3)
self.assertAlmostEqual(row.bal_val, last_sle.stock_value, 3)
# ----------- tests # ----------- tests
def test_basic_stock_balance(self): def test_basic_stock_balance(self):
@ -79,7 +104,7 @@ class TestStockBalance(FrappeTestCase):
}, },
rows[0], rows[0],
) )
self.assertBasicInvariants(rows) self.assertInvariants(rows)
def test_opening_balance(self): def test_opening_balance(self):
self.generate_stock_ledger( self.generate_stock_ledger(
@ -91,12 +116,12 @@ class TestStockBalance(FrappeTestCase):
], ],
) )
rows = stock_balance(self.filters) rows = stock_balance(self.filters)
self.assertBasicInvariants(rows) self.assertInvariants(rows)
rows = stock_balance(self.filters.update({"from_date": "2021-01-02"})) rows = stock_balance(self.filters.update({"from_date": "2021-01-02"}))
self.assertBasicInvariants(rows) self.assertInvariants(rows)
self.assertPartialDictionary({"opening_qty": 1, "in_qty": 5}, rows[0]) self.assertPartialDictionary({"opening_qty": 1, "in_qty": 5}, rows[0])
rows = stock_balance(self.filters.update({"from_date": "2022-01-01"})) rows = stock_balance(self.filters.update({"from_date": "2022-01-01"}))
self.assertBasicInvariants(rows) self.assertInvariants(rows)
self.assertPartialDictionary({"opening_qty": 6, "in_qty": 0}, rows[0]) self.assertPartialDictionary({"opening_qty": 6, "in_qty": 0}, rows[0])