Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: [concurrency issue] incorrect picked qty in sales order

Browse Source
This commit is contained in:
Rohit Waghchaure 2023-01-02 18:46:22 +05:30
parent 617518389a
commit aba83849a6
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/stock/doctype/pick_list/pick_list.py
View File

@ -100,6 +100,7 @@ class PickList(Document):
item_table, item_table,
item.sales_order_item, item.sales_order_item,
["picked_qty", stock_qty_field], ["picked_qty", stock_qty_field],
for_update=True,
) )
if self.docstatus == 1: if self.docstatus == 1:
@ -118,7 +119,7 @@ class PickList(Document):
def update_sales_order_picking_status(sales_orders: Set[str]) -> None: def update_sales_order_picking_status(sales_orders: Set[str]) -> None:
for sales_order in sales_orders: for sales_order in sales_orders:
if sales_order: if sales_order:
frappe.get_doc("Sales Order", sales_order).update_picking_status() frappe.get_doc("Sales Order", sales_order, for_update=True).update_picking_status()
@frappe.whitelist() @frappe.whitelist()
def set_item_locations(self, save=False): def set_item_locations(self, save=False):
@ -262,7 +263,7 @@ class PickList(Document):
for so_row, item_code in product_bundles.items(): for so_row, item_code in product_bundles.items():
picked_qty = self._compute_picked_qty_for_bundle(so_row, product_bundle_qty_map[item_code]) picked_qty = self._compute_picked_qty_for_bundle(so_row, product_bundle_qty_map[item_code])
item_table = "Sales Order Item" item_table = "Sales Order Item"
already_picked = frappe.db.get_value(item_table, so_row, "picked_qty") already_picked = frappe.db.get_value(item_table, so_row, "picked_qty", for_update=True)
frappe.db.set_value( frappe.db.set_value(
item_table, item_table,
so_row, so_row,