perf: use create_custom_fields (#31853)

* perf: use `create_custom_fields`

* fix: default must be a string

erpnext/erpnext_integrations/doctype/tally_migration/tally_migration.py

@@ -12,7 +12,9 @@ from decimal import Decimal
 import frappe
 from bs4 import BeautifulSoup as bs
 from frappe import _
-from frappe.custom.doctype.custom_field.custom_field import create_custom_field
+from frappe.custom.doctype.custom_field.custom_field import (
+	create_custom_fields as _create_custom_fields,
+)
 from frappe.model.document import Document
 from frappe.utils.data import format_datetime
 
@@ -577,22 +579,25 @@ class TallyMigration(Document):
 				new_year.save()
 				oldest_year = new_year
 
-		def create_custom_fields(doctypes):
+		def create_custom_fields():
-			tally_guid_df = {
+			_create_custom_fields(
-				"fieldtype": "Data",
+				{
-				"fieldname": "tally_guid",
+					("Journal Entry", "Purchase Invoice", "Sales Invoice"): [
-				"read_only": 1,
+						{
-				"label": "Tally GUID",
+							"fieldtype": "Data",
-			}
+							"fieldname": "tally_guid",
-			tally_voucher_no_df = {
+							"read_only": 1,
-				"fieldtype": "Data",
+							"label": "Tally GUID",
-				"fieldname": "tally_voucher_no",
+						},
-				"read_only": 1,
+						{
-				"label": "Tally Voucher Number",
+							"fieldtype": "Data",
-			}
+							"fieldname": "tally_voucher_no",
-			for df in [tally_guid_df, tally_voucher_no_df]:
+							"read_only": 1,
-				for doctype in doctypes:
+							"label": "Tally Voucher Number",
-					create_custom_field(doctype, df)
+						},
+					]
+				}
+			)
 
 		def create_price_list():
 			frappe.get_doc(
@@ -628,7 +633,7 @@ class TallyMigration(Document):
 
 			create_fiscal_years(vouchers)
 			create_price_list()
-			create_custom_fields(["Journal Entry", "Purchase Invoice", "Sales Invoice"])
+			create_custom_fields()
 
 			total = len(vouchers)
 			is_last = False

erpnext/erpnext_integrations/doctype/woocommerce_settings/woocommerce_settings.py

@@ -6,7 +6,7 @@ from urllib.parse import urlparse
 
 import frappe
 from frappe import _
-from frappe.custom.doctype.custom_field.custom_field import create_custom_field
+from frappe.custom.doctype.custom_field.custom_field import create_custom_fields
 from frappe.model.document import Document
 from frappe.utils.nestedset import get_root_of
 
@@ -19,27 +19,24 @@ class WoocommerceSettings(Document):
 
 	def create_delete_custom_fields(self):
 		if self.enable_sync:
-			custom_fields = {}
+			create_custom_fields(
-			# create
+				{
-			for doctype in ["Customer", "Sales Order", "Item", "Address"]:
+					("Customer", "Sales Order", "Item", "Address"): dict(
-				df = dict(
+						fieldname="woocommerce_id",
-					fieldname="woocommerce_id",
+						label="Woocommerce ID",
-					label="Woocommerce ID",
+						fieldtype="Data",
-					fieldtype="Data",
+						read_only=1,
-					read_only=1,
+						print_hide=1,
-					print_hide=1,
+					),
-				)
+					("Customer", "Address"): dict(
-				create_custom_field(doctype, df)
+						fieldname="woocommerce_email",
-
+						label="Woocommerce Email",
-			for doctype in ["Customer", "Address"]:
+						fieldtype="Data",
-				df = dict(
+						read_only=1,
-					fieldname="woocommerce_email",
+						print_hide=1,
-					label="Woocommerce Email",
+					),
-					fieldtype="Data",
+				}
-					read_only=1,
+			)
-					print_hide=1,
-				)
-				create_custom_field(doctype, df)
 
 			if not frappe.get_value("Item Group", {"name": _("WooCommerce Products")}):
 				item_group = frappe.new_doc("Item Group")

erpnext/setup/install.py

@@ -4,7 +4,7 @@
 
 import frappe
 from frappe import _
-from frappe.custom.doctype.custom_field.custom_field import create_custom_field
+from frappe.custom.doctype.custom_field.custom_field import create_custom_fields
 from frappe.desk.page.setup_wizard.setup_wizard import add_all_roles_to
 from frappe.utils import cint
 
@@ -83,35 +83,32 @@ def setup_currency_exchange():
 
 
 def create_print_setting_custom_fields():
-	create_custom_field(
+	create_custom_fields(
-		"Print Settings",
 		{
-			"label": _("Compact Item Print"),
+			"Print Settings": [
-			"fieldname": "compact_item_print",
+				{
-			"fieldtype": "Check",
+					"label": _("Compact Item Print"),
-			"default": 1,
+					"fieldname": "compact_item_print",
-			"insert_after": "with_letterhead",
+					"fieldtype": "Check",
-		},
+					"default": "1",
-	)
+					"insert_after": "with_letterhead",
-	create_custom_field(
+				},
-		"Print Settings",
+				{
-		{
+					"label": _("Print UOM after Quantity"),
-			"label": _("Print UOM after Quantity"),
+					"fieldname": "print_uom_after_quantity",
-			"fieldname": "print_uom_after_quantity",
+					"fieldtype": "Check",
-			"fieldtype": "Check",
+					"default": "0",
-			"default": 0,
+					"insert_after": "compact_item_print",
-			"insert_after": "compact_item_print",
+				},
-		},
+				{
-	)
+					"label": _("Print taxes with zero amount"),
-	create_custom_field(
+					"fieldname": "print_taxes_with_zero_amount",
-		"Print Settings",
+					"fieldtype": "Check",
-		{
+					"default": "0",
-			"label": _("Print taxes with zero amount"),
+					"insert_after": "allow_print_for_cancelled",
-			"fieldname": "print_taxes_with_zero_amount",
+				},
-			"fieldtype": "Check",
+			]
-			"default": 0,
+		}
-			"insert_after": "allow_print_for_cancelled",
-		},
 	)