Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix(setup wizard): Validate FY dates (#15419)

Browse Source 
- start date should be less than end date
This commit is contained in:
Faris Ansari 2018-09-18 10:42:04 +05:30 committed by Nabin Hait
parent ada13213c0
commit aa856c474a
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
erpnext/public/js/setup_wizard.js
View File

@ -141,9 +141,7 @@ erpnext.setup.slides_settings = [
let me = this;
let exist;
// validate fiscal year start and end dates
if (this.values.fy_start_date == 'Invalid date' || this.values.fy_end_date == 'Invalid date') {
frappe.msgprint(__("Please enter valid Financial Year Start and End Dates"));
if (!this.validate_fy_dates()) {
return false;
}
@ -170,6 +168,20 @@ erpnext.setup.slides_settings = [
return true;
},
validate_fy_dates: function() {
// validate fiscal year start and end dates
const invalid = this.values.fy_start_date == 'Invalid date' ||
this.values.fy_end_date == 'Invalid date';
const start_greater_than_end = this.values.fy_start_date > this.values.fy_end_date;
if (invalid || start_greater_than_end) {
frappe.msgprint(__("Please enter valid Financial Year Start and End Dates"));
return false;
}
return true;
},
set_fy_dates: function (slide) {
var country = frappe.wizard.values.country;