Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #36434 from ruthra-kumar/replace_get_cached_with_get_single_value

Browse Source 
fix: incorrect usage `get_cached_value` on single doctypes
This commit is contained in:
ruthra kumar 2023-08-01 10:02:33 +05:30 committed by GitHub
commit a93ae9c826
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/accounts/deferred_revenue.py
View File

@ -341,7 +341,7 @@ def book_deferred_income_or_expense(doc, deferred_process, posting_date=None):
"enable_deferred_revenue" if doc.doctype == "Sales Invoice" else "enable_deferred_expense" "enable_deferred_revenue" if doc.doctype == "Sales Invoice" else "enable_deferred_expense"
) )
accounts_frozen_upto = frappe.get_cached_value("Accounts Settings", "None", "acc_frozen_upto") accounts_frozen_upto = frappe.db.get_single_value("Accounts Settings", "acc_frozen_upto")
def _book_deferred_revenue_or_expense( def _book_deferred_revenue_or_expense(
item, item,

2
erpnext/accounts/doctype/purchase_invoice/purchase_invoice.py
View File

@ -229,7 +229,7 @@ class PurchaseInvoice(BuyingController):
) )
if ( if (
cint(frappe.get_cached_value("Buying Settings", "None", "maintain_same_rate")) cint(frappe.db.get_single_value("Buying Settings", "maintain_same_rate"))
and not self.is_return and not self.is_return
and not self.is_internal_supplier and not self.is_internal_supplier
): ):

2
erpnext/selling/doctype/sales_order/sales_order.py
View File

@ -50,7 +50,7 @@ class SalesOrder(SellingController):
super(SalesOrder, self).__init__(*args, **kwargs) super(SalesOrder, self).__init__(*args, **kwargs)
def onload(self) -> None: def onload(self) -> None:
if frappe.get_cached_value("Stock Settings", None, "enable_stock_reservation"): if frappe.db.get_single_value("Stock Settings", "enable_stock_reservation"):
if self.has_unreserved_stock(): if self.has_unreserved_stock():
self.set_onload("has_unreserved_stock", True) self.set_onload("has_unreserved_stock", True)

2
erpnext/stock/doctype/price_list/price_list.py
View File

@ -45,7 +45,7 @@ class PriceList(Document):
doc_before_save = self.get_doc_before_save() doc_before_save = self.get_doc_before_save()
currency_changed = self.currency != doc_before_save.currency currency_changed = self.currency != doc_before_save.currency
affects_cart = self.name == frappe.get_cached_value("E Commerce Settings", None, "price_list") affects_cart = self.name == frappe.db.get_single_value("E Commerce Settings", "price_list")
if currency_changed and affects_cart: if currency_changed and affects_cart:
validate_cart_settings() validate_cart_settings()