Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

refactor: raise exception on invalid date

Browse Source
This commit is contained in:
ruthra kumar 2023-11-13 10:39:40 +05:30
parent a52a1b49af
commit a393a6b76c
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.js
View File

@ -14,7 +14,7 @@ frappe.ui.form.on("Bulk Transaction Log", {
frappe.call({ frappe.call({
method: "erpnext.utilities.bulk_transaction.retry", method: "erpnext.utilities.bulk_transaction.retry",
args: {date: frm.doc.date} args: {date: frm.doc.date}
}).then(()=> { }); });
}); });
} }
}, },

7
erpnext/bulk_transaction/doctype/bulk_transaction_log/bulk_transaction_log.py
View File

@ -15,6 +15,13 @@ class BulkTransactionLog(Document):
def load_from_db(self): def load_from_db(self):
log_detail = qb.DocType("Bulk Transaction Log Detail") log_detail = qb.DocType("Bulk Transaction Log Detail")
has_records = frappe.db.sql(
f"select exists (select * from `tabBulk Transaction Log Detail` where date = '{self.name}');"
)[0][0]
if not has_records:
raise frappe.DoesNotExistError
succeeded_logs = ( succeeded_logs = (
qb.from_(log_detail) qb.from_(log_detail)
.select(Count(log_detail.date).as_("count")) .select(Count(log_detail.date).as_("count"))