From 1905239ec251df473b1c32b848c824184f7d86fc Mon Sep 17 00:00:00 2001 From: s-aga-r Date: Wed, 31 May 2023 15:30:45 +0530 Subject: [PATCH] fix(ux): throw if no row selected to create repost entries --- .../stock_and_account_value_comparison.js | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.js b/erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.js index 50a78a8258..254f5273be 100644 --- a/erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.js +++ b/erpnext/stock/report/stock_and_account_value_comparison/stock_and_account_value_comparison.js @@ -53,11 +53,14 @@ frappe.query_reports["Stock and Account Value Comparison"] = {

Are you sure you want to create Reposting Entries?

`; + let indexes = frappe.query_report.datatable.rowmanager.getCheckedRows(); + let selected_rows = indexes.map(i => frappe.query_report.data[i]); + + if (!selected_rows.length) { + frappe.throw(__("Please select rows to create Reposting Entries")); + } frappe.confirm(__(message), () => { - let indexes = frappe.query_report.datatable.rowmanager.getCheckedRows(); - let selected_rows = indexes.map(i => frappe.query_report.data[i]); - frappe.call({ method: "erpnext.stock.report.stock_and_account_value_comparison.stock_and_account_value_comparison.create_reposting_entries", args: {