From 68dbf7f99cb8e4282f1493cc19d0cbc8096fead0 Mon Sep 17 00:00:00 2001 From: Faris Ansari Date: Fri, 2 Nov 2018 13:30:51 +0530 Subject: [PATCH] fix: Use frappe.utils.make_event_emitter --- erpnext/public/js/hub/event_emitter.js | 31 -------------------------- erpnext/public/js/hub/marketplace.js | 5 ++--- 2 files changed, 2 insertions(+), 34 deletions(-) delete mode 100644 erpnext/public/js/hub/event_emitter.js diff --git a/erpnext/public/js/hub/event_emitter.js b/erpnext/public/js/hub/event_emitter.js deleted file mode 100644 index 1e7288191d..0000000000 --- a/erpnext/public/js/hub/event_emitter.js +++ /dev/null @@ -1,31 +0,0 @@ -/** - * Simple EventEmitter which uses jQuery's event system - */ -class EventEmitter { - init() { - this.jq = jQuery(this); - } - - trigger(evt, data) { - !this.jq && this.init(); - this.jq.trigger(evt, data); - } - - once(evt, handler) { - !this.jq && this.init(); - this.jq.one(evt, (e, data) => handler(data)); - } - - on(evt, handler) { - !this.jq && this.init(); - this.jq.bind(evt, (e, data) => handler(data)); - } - - off(evt, handler) { - !this.jq && this.init(); - this.jq.unbind(evt, (e, data) => handler(data)); - } -} - - -export default EventEmitter; \ No newline at end of file diff --git a/erpnext/public/js/hub/marketplace.js b/erpnext/public/js/hub/marketplace.js index 7ef87c4eb6..a1596e0043 100644 --- a/erpnext/public/js/hub/marketplace.js +++ b/erpnext/public/js/hub/marketplace.js @@ -8,14 +8,13 @@ import { ProfileDialog } from './components/profile_dialog'; // helpers import './hub_call'; -import EventEmitter from './event_emitter'; frappe.provide('hub'); frappe.provide('erpnext.hub'); frappe.provide('frappe.route'); -$.extend(erpnext.hub, EventEmitter.prototype); -$.extend(frappe.route, EventEmitter.prototype); +frappe.utils.make_event_emitter(frappe.route); +frappe.utils.make_event_emitter(erpnext.hub); erpnext.hub.Marketplace = class Marketplace { constructor({ parent }) {