fix: removed "standard working hours" also fixed test cases
This commit is contained in:
parent
4e37d25374
commit
a07a548622
@ -140,52 +140,6 @@ class TestTimesheet(unittest.TestCase):
|
|||||||
settings.ignore_employee_time_overlap = initial_setting
|
settings.ignore_employee_time_overlap = initial_setting
|
||||||
settings.save()
|
settings.save()
|
||||||
|
|
||||||
def test_timesheet_std_working_hours(self):
|
|
||||||
emp = make_employee("test_employee_6@salary.com")
|
|
||||||
|
|
||||||
company = frappe.get_doc('Company', "_Test Company")
|
|
||||||
company.standard_working_hours = 8
|
|
||||||
company.save()
|
|
||||||
|
|
||||||
timesheet = frappe.new_doc("Timesheet")
|
|
||||||
timesheet.employee = emp
|
|
||||||
timesheet.company = '_Test Company'
|
|
||||||
timesheet.append(
|
|
||||||
'time_logs',
|
|
||||||
{
|
|
||||||
"activity_type": "_Test Activity Type",
|
|
||||||
"from_time": now_datetime(),
|
|
||||||
"to_time": now_datetime() + datetime.timedelta(days= 4)
|
|
||||||
}
|
|
||||||
)
|
|
||||||
timesheet.save()
|
|
||||||
|
|
||||||
ts = frappe.get_doc('Timesheet', timesheet.name)
|
|
||||||
self.assertEqual(ts.total_hours, 32)
|
|
||||||
ts.submit()
|
|
||||||
ts.cancel()
|
|
||||||
|
|
||||||
company = frappe.get_doc('Company', "_Test Company")
|
|
||||||
company.standard_working_hours = 0
|
|
||||||
company.save()
|
|
||||||
|
|
||||||
timesheet = frappe.new_doc("Timesheet")
|
|
||||||
timesheet.employee = emp
|
|
||||||
timesheet.company = '_Test Company'
|
|
||||||
timesheet.append(
|
|
||||||
'time_logs',
|
|
||||||
{
|
|
||||||
"activity_type": "_Test Activity Type",
|
|
||||||
"from_time": now_datetime(),
|
|
||||||
"to_time": now_datetime() + datetime.timedelta(days= 4)
|
|
||||||
}
|
|
||||||
)
|
|
||||||
timesheet.save()
|
|
||||||
|
|
||||||
ts = frappe.get_doc('Timesheet', timesheet.name)
|
|
||||||
self.assertEqual(ts.total_hours, 96)
|
|
||||||
ts.submit()
|
|
||||||
ts.cancel()
|
|
||||||
|
|
||||||
def make_salary_structure_for_timesheet(employee):
|
def make_salary_structure_for_timesheet(employee):
|
||||||
salary_structure_name = "Timesheet Salary Structure Test"
|
salary_structure_name = "Timesheet Salary Structure Test"
|
||||||
|
|||||||
@ -24,7 +24,6 @@ class Timesheet(Document):
|
|||||||
self.set_status()
|
self.set_status()
|
||||||
self.validate_dates()
|
self.validate_dates()
|
||||||
self.validate_time_logs()
|
self.validate_time_logs()
|
||||||
self.calculate_std_hours()
|
|
||||||
self.update_cost()
|
self.update_cost()
|
||||||
self.calculate_total_amounts()
|
self.calculate_total_amounts()
|
||||||
self.calculate_percentage_billed()
|
self.calculate_percentage_billed()
|
||||||
@ -91,17 +90,6 @@ class Timesheet(Document):
|
|||||||
self.start_date = getdate(start_date)
|
self.start_date = getdate(start_date)
|
||||||
self.end_date = getdate(end_date)
|
self.end_date = getdate(end_date)
|
||||||
|
|
||||||
def calculate_std_hours(self):
|
|
||||||
std_working_hours = frappe.get_value("Company", self.company, 'standard_working_hours')
|
|
||||||
|
|
||||||
for time in self.time_logs:
|
|
||||||
if time.from_time and time.to_time:
|
|
||||||
if flt(std_working_hours) and date_diff(time.to_time, time.from_time):
|
|
||||||
time.hours = flt(std_working_hours) * date_diff(time.to_time, time.from_time)
|
|
||||||
else:
|
|
||||||
if not time.hours:
|
|
||||||
time.hours = time_diff_in_hours(time.to_time, time.from_time)
|
|
||||||
|
|
||||||
def before_cancel(self):
|
def before_cancel(self):
|
||||||
self.set_status()
|
self.set_status()
|
||||||
|
|
||||||
|
|||||||
@ -22,7 +22,6 @@
|
|||||||
"default_letter_head",
|
"default_letter_head",
|
||||||
"default_holiday_list",
|
"default_holiday_list",
|
||||||
"default_finance_book",
|
"default_finance_book",
|
||||||
"standard_working_hours",
|
|
||||||
"default_selling_terms",
|
"default_selling_terms",
|
||||||
"default_buying_terms",
|
"default_buying_terms",
|
||||||
"default_warehouse_for_sales_return",
|
"default_warehouse_for_sales_return",
|
||||||
@ -238,11 +237,6 @@
|
|||||||
"label": "Default Holiday List",
|
"label": "Default Holiday List",
|
||||||
"options": "Holiday List"
|
"options": "Holiday List"
|
||||||
},
|
},
|
||||||
{
|
|
||||||
"fieldname": "standard_working_hours",
|
|
||||||
"fieldtype": "Float",
|
|
||||||
"label": "Standard Working Hours"
|
|
||||||
},
|
|
||||||
{
|
{
|
||||||
"fieldname": "default_warehouse_for_sales_return",
|
"fieldname": "default_warehouse_for_sales_return",
|
||||||
"fieldtype": "Link",
|
"fieldtype": "Link",
|
||||||
@ -730,7 +724,7 @@
|
|||||||
"image_field": "company_logo",
|
"image_field": "company_logo",
|
||||||
"is_tree": 1,
|
"is_tree": 1,
|
||||||
"links": [],
|
"links": [],
|
||||||
"modified": "2020-03-21 18:09:53.534211",
|
"modified": "2020-06-24 12:45:31.462195",
|
||||||
"modified_by": "Administrator",
|
"modified_by": "Administrator",
|
||||||
"module": "Setup",
|
"module": "Setup",
|
||||||
"name": "Company",
|
"name": "Company",
|
||||||
|
|||||||
Loading…
x
Reference in New Issue
Block a user