Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: make DN item reference mandatory for Packing Slip Item

Browse Source
This commit is contained in:
s-aga-r 2023-04-28 15:40:26 +05:30
parent 372bce4567
commit 9e5b102768
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/stock/doctype/packing_slip/packing_slip.py
View File

@ -38,6 +38,7 @@ class PackingSlip(StatusUpdater):
self.validate_delivery_note()
self.validate_case_nos()
self.validate_mandatory()
validate_uom_is_integer(self, "stock_uom", "qty")
validate_uom_is_integer(self, "weight_uom", "net_weight")
@ -90,6 +91,13 @@ class PackingSlip(StatusUpdater):
)
)
def validate_mandatory(self):
for item in self.items:
if not item.dn_detail and not item.pi_detail:
frappe.throw(
_("Row {0}: Either Delivery Note Item or Packed Item reference is mandatory").format(item.idx)
)
def set_missing_values(self):
if not self.from_case_no:
self.from_case_no = self.get_recommended_case_no()