From 9e0762e8c2c3643268c98c62253fa5a7210af71b Mon Sep 17 00:00:00 2001 From: "hello@openetech.com" Date: Wed, 23 Oct 2019 19:14:14 +0530 Subject: [PATCH] code review changes --- .../import_supplier_invoice.py | 29 +++++-------------- 1 file changed, 7 insertions(+), 22 deletions(-) diff --git a/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py b/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py index 293d6c908e..33884787a2 100644 --- a/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py +++ b/erpnext/regional/doctype/import_supplier_invoice/import_supplier_invoice.py @@ -164,19 +164,13 @@ class ImportSupplierInvoice(Document): city = city, province = province, pin_code = pin_code, country = country) - pi_name = create_purchase_invoice(company = self.company, - naming_series = self.invoice_series, - supplier_name = supplier_name, - bill_no = invoice_no, - document_type = document_type, - bill_date = bill_date, - is_return = return_invoice, - destination_code = destination_code, - total_discount = total_discount, - items = items, - taxes = taxes, - terms = terms, - file_name = file_name) + pi_name = create_purchase_invoice(company = self.company, naming_series = self.invoice_series, + supplier_name = supplier_name, bill_no = invoice_no, + document_type = document_type, bill_date = bill_date, + is_return = return_invoice, destination_code = destination_code, + total_discount = total_discount, items = items, + taxes = taxes, terms = terms,file_name = file_name) + file_count += 1 if pi_name: pi_count += 1 @@ -365,15 +359,6 @@ def create_uom(uom): new_uom.save() return new_uom.uom_name -def check_bill_no(invoice_no): - - existing_bill_no = frappe.db.get_value("Purchase Invoice", - filters={"bill_no": invoice_no, "docstatus": 1}, fieldname="name") - if existing_bill_no: - return existing_bill_no - else: - return None - def get_full_path(file_name): """Returns file path from given file name""" file_path = file_name