Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix excess amount calculation in loan refund

Browse Source
This commit is contained in:
Labeeb Mattra 2022-07-08 17:52:36 +05:30
parent 245b0c7818
commit 9df1413adb
1 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
erpnext/loan_management/doctype/loan_refund/loan_refund.py
View File

@ -4,10 +4,13 @@
import frappe import frappe
from frappe import _ from frappe import _
from frappe.model.document import Document from frappe.model.document import Document
from frappe.utils import cint, flt, getdate from frappe.utils import cint, getdate
import erpnext import erpnext
from erpnext.accounts.general_ledger import make_gl_entries from erpnext.accounts.general_ledger import make_gl_entries
from erpnext.loan_management.doctype.loan_repayment.loan_repayment import (
get_pending_principal_amount,
)
class LoanRefund(Document): class LoanRefund(Document):
@ -31,10 +34,12 @@ class LoanRefund(Document):
["total_payment", "total_principal_paid", "total_interest_payable", "written_off_amount"], ["total_payment", "total_principal_paid", "total_interest_payable", "written_off_amount"],
) )
excess_amount = flt( loan = frappe.get_doc("Loan", self.loan)
flt(total_payment) - flt(interest_payable) - flt(principal_paid) - flt(written_off_amount), pending_amount = get_pending_principal_amount(loan)
precision, if pending_amount >= 0:
) frappe.throw(_("No excess amount to refund."))
else:
excess_amount = pending_amount * -1
if self.refund_amount > excess_amount: if self.refund_amount > excess_amount:
frappe.throw(_("Refund amount cannot be greater than excess amount {}".format(excess_amount))) frappe.throw(_("Refund amount cannot be greater than excess amount {}".format(excess_amount)))