From 9b08062bed3c1189d4c16128b6aaa86244cc63fc Mon Sep 17 00:00:00 2001 From: Neil Trini Lasrado Date: Thu, 9 Oct 2014 17:26:17 +0530 Subject: [PATCH] employee cannot report to himself validation added to employee doctype --- erpnext/hr/doctype/employee/employee.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/erpnext/hr/doctype/employee/employee.py b/erpnext/hr/doctype/employee/employee.py index fa2594b103..16ae758b1b 100644 --- a/erpnext/hr/doctype/employee/employee.py +++ b/erpnext/hr/doctype/employee/employee.py @@ -39,6 +39,7 @@ class Employee(Document): self.validate_email() self.validate_status() self.validate_employee_leave_approver() + self.validate_reports_to() if self.user_id: self.validate_for_enabled_user_id() @@ -141,6 +142,10 @@ class Employee(Document): self.get("employee_leave_approvers").remove(l) msgprint(_("{0} is not a valid Leave Approver. Removing row #{1}.").format(l.leave_approver, l.idx)) + def validate_reports_to(self): + if self.reports_to == self.name: + throw(_("Employee cannot report to himself.")) + def update_dob_event(self): if self.status == "Active" and self.date_of_birth \ and not cint(frappe.db.get_value("HR Settings", None, "stop_birthday_reminders")):