Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #25195 from ankush/use_isinstance_instead_of_type

Browse Source 
fix: broken type check in stock ageing report
This commit is contained in:
Deepesh Garg 2021-04-13 15:24:53 +05:30 committed by GitHub
commit 9aad73b9f0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
erpnext/stock/report/stock_ageing/stock_ageing.py
View File

@ -49,7 +49,7 @@ def get_average_age(fifo_queue, to_date):
for batch in fifo_queue: for batch in fifo_queue:
batch_age = date_diff(to_date, batch[1]) batch_age = date_diff(to_date, batch[1])
if type(batch[0]) in ['int', 'float']: if isinstance(batch[0], (int, float)):
age_qty += batch_age * batch[0] age_qty += batch_age * batch[0]
total_qty += batch[0] total_qty += batch[0]
else: else:
@ -302,4 +302,4 @@ def add_column(range_columns, label, fieldname, fieldtype='Float', width=140):
fieldname=fieldname, fieldname=fieldname,
fieldtype=fieldtype, fieldtype=fieldtype,
width=width width=width
)) ))