Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Merge pull request #36208 from rohitwaghchaure/fixed-filter-mandatory-for-batch-wise-balance-report

Browse Source 
fix: made item or warehouse filter mandatory
This commit is contained in:
rohitwaghchaure 2023-07-20 18:02:37 +05:30 committed by GitHub
commit 9a9939cfb3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
erpnext/stock/report/batch_wise_balance_history/batch_wise_balance_history.py
View File

@ -10,11 +10,18 @@ from pypika import functions as fn
from erpnext.stock.doctype.warehouse.warehouse import apply_warehouse_filter from erpnext.stock.doctype.warehouse.warehouse import apply_warehouse_filter
SLE_COUNT_LIMIT = 10_000
def execute(filters=None): def execute(filters=None):
if not filters: if not filters:
filters = {} filters = {}
sle_count = frappe.db.count("Stock Ledger Entry", {"is_cancelled": 0})
if sle_count > SLE_COUNT_LIMIT and not filters.get("item_code") and not filters.get("warehouse"):
frappe.throw(_("Please select either the Item or Warehouse filter to generate the report."))
if filters.from_date > filters.to_date: if filters.from_date > filters.to_date:
frappe.throw(_("From Date must be before To Date")) frappe.throw(_("From Date must be before To Date"))