From 5b34d00bc08794de072e03b042d583658006d8ef Mon Sep 17 00:00:00 2001 From: Shreya Shah Date: Mon, 8 Oct 2018 18:20:51 +0530 Subject: [PATCH 1/3] fix(accounts-receivable): Column values in Print and PDF (#15622) --- .../accounts_receivable/accounts_receivable.html | 10 +++++----- .../report/accounts_receivable/accounts_receivable.py | 9 +++++++-- 2 files changed, 12 insertions(+), 7 deletions(-) diff --git a/erpnext/accounts/report/accounts_receivable/accounts_receivable.html b/erpnext/accounts/report/accounts_receivable/accounts_receivable.html index 9fefc03716..0a21181399 100644 --- a/erpnext/accounts/report/accounts_receivable/accounts_receivable.html +++ b/erpnext/accounts/report/accounts_receivable/accounts_receivable.html @@ -161,21 +161,21 @@ {% } %} - {%= format_currency(data[i]["Invoiced Amount"], data[i]["currency"]) %} + {%= format_currency(data[i]["invoiced_amount"], data[i]["currency"]) %} {% if(!filters.show_pdc_in_print) { %} - {%= format_currency(data[i]["Paid Amount"], data[i]["currency"]) %} + {%= format_currency(data[i]["paid_amount"], data[i]["currency"]) %} - {%= report.report_name === "Accounts Receivable" ? format_currency(data[i]["Credit Note"], data[i]["currency"]) : format_currency(data[i]["Debit Note"], data[i]["currency"]) %} + {%= report.report_name === "Accounts Receivable" ? format_currency(data[i]["credit_note"], data[i]["currency"]) : format_currency(data[i]["Debit Note"], data[i]["currency"]) %} {% } %} - {%= format_currency(data[i]["Outstanding Amount"], data[i]["currency"]) %} + {%= format_currency(data[i]["outstanding_amount"], data[i]["currency"]) %} {% if(filters.show_pdc_in_print) { %} {% if(report.report_name === "Accounts Receivable") { %} - {%= data[i][__("Customer LPO")] %} + {%= data[i]["po_no"] %} {% } %} {%= frappe.datetime.str_to_user(data[i][__("PDC/LC Date")]) %} {%= data[i][__("PDC/LC Ref")] %} diff --git a/erpnext/accounts/report/accounts_receivable/accounts_receivable.py b/erpnext/accounts/report/accounts_receivable/accounts_receivable.py index 98a6d43c76..0425fe5136 100644 --- a/erpnext/accounts/report/accounts_receivable/accounts_receivable.py +++ b/erpnext/accounts/report/accounts_receivable/accounts_receivable.py @@ -60,6 +60,7 @@ class ReceivablePayableReport(object): for label in ("Invoiced Amount", "Paid Amount", credit_or_debit_note, "Outstanding Amount"): columns.append({ "label": label, + "fieldname": frappe.scrub(label), "fieldtype": "Currency", "options": "currency", "width": 120 @@ -103,9 +104,13 @@ class ReceivablePayableReport(object): ] if args.get('party_type') == 'Customer': - columns += [_("Customer LPO") + ":Data:100"] + columns.append({ + "label": _("Customer LPO"), + "fieldtype": "Data", + "fieldname": "po_no", + "width": 100, + }) columns += [_("Delivery Note") + ":Data:100"] - if args.get("party_type") == "Customer": columns += [ _("Territory") + ":Link/Territory:80", From a1036ad50bf444238e23be9685c8410beaa6a50f Mon Sep 17 00:00:00 2001 From: Zlash65 Date: Tue, 9 Oct 2018 17:38:28 +0530 Subject: [PATCH 2/3] setup wizard failing fix --- erpnext/setup/setup_wizard/operations/taxes_setup.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/setup/setup_wizard/operations/taxes_setup.py b/erpnext/setup/setup_wizard/operations/taxes_setup.py index 50bea41301..d7f95e8640 100644 --- a/erpnext/setup/setup_wizard/operations/taxes_setup.py +++ b/erpnext/setup/setup_wizard/operations/taxes_setup.py @@ -30,7 +30,7 @@ def make_tax_account_and_template(company, account_name, tax_rate, template_name if accounts: make_sales_and_purchase_tax_templates(accounts, template_name) except frappe.NameError: - frappe.message_log.pop() + if frappe.message_log: frappe.message_log.pop() except RootNotEditable: pass From 2dc89727947803a2268d5384c179451e53afad3c Mon Sep 17 00:00:00 2001 From: Saurabh Date: Tue, 9 Oct 2018 18:25:32 +0600 Subject: [PATCH 3/3] bumped to version 10.1.58 --- erpnext/__init__.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/erpnext/__init__.py b/erpnext/__init__.py index 0457b7e477..ae01237f54 100644 --- a/erpnext/__init__.py +++ b/erpnext/__init__.py @@ -5,7 +5,7 @@ import frappe from erpnext.hooks import regional_overrides from frappe.utils import getdate -__version__ = '10.1.57' +__version__ = '10.1.58' def get_default_company(user=None): '''Get default company for user'''