Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: only check for payment_account on bank entry (#21445)

Browse Source 
* fix: only check for payment_account on bank entry

Since all the fields (company, start and end date are mandatory before form submission, there is no need to check for them again after submission.

* fix: cur_frm to frm

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
This commit is contained in:
Michelle Alva 2020-04-30 16:24:51 +05:30 committed by GitHub
parent a8779872ee
commit 95b186268c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
erpnext/hr/doctype/payroll_entry/payroll_entry.js
View File

@ -249,7 +249,7 @@ const submit_salary_slip = function (frm) {
let make_bank_entry = function (frm) { let make_bank_entry = function (frm) {
var doc = frm.doc; var doc = frm.doc;
if (doc.company && doc.start_date && doc.end_date && doc.payment_account) { if (doc.payment_account) {
return frappe.call({ return frappe.call({
doc: cur_frm.doc, doc: cur_frm.doc,
method: "make_payment_entry", method: "make_payment_entry",
@ -262,7 +262,8 @@ let make_bank_entry = function (frm) {
freeze_message: __("Creating Payment Entries......") freeze_message: __("Creating Payment Entries......")
}); });
} else { } else {
frappe.msgprint(__("Company, Payment Account, From Date and To Date is mandatory")); frappe.msgprint(__("Payment Account is mandatory"));
frm.scroll_to_field('payment_account');
} }
}; };